Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FireFox v.27.0 Arrow Problem #70

Open
swiftusa opened this issue Feb 6, 2014 · 14 comments
Open

New FireFox v.27.0 Arrow Problem #70

swiftusa opened this issue Feb 6, 2014 · 14 comments
Assignees

Comments

@swiftusa
Copy link

swiftusa commented Feb 6, 2014

Hello,
hint.css has been my very favorite tooltip script. I had been using hint for over a month.

I was using FireFox v.26.0 with no problems, but today morning FireFox automatically upgraded to v.27.0.

Now the shape of the tooltip arrow is crumbled, but the shape of the box is fine. This problem is only in FireFox and not in Chrome. I then tested this on a different computer with FireFox v.26.0 and the tooltip arrow was okay, I then upgraded the FireFox to v.27.0 and the same problem is replicated.

Can you please test hint.css on FireFox v.27.0 and share your experience?

Best Regards,
Sanson

@pacanukeha
Copy link

pacanukeha commented Feb 6, 2014

Works fine for me using Firefox Aurora (28.0a2 (2014-02-03))

@swiftusa
Copy link
Author

swiftusa commented Feb 6, 2014

"Firefox Aurora" is hardly used by 1% of internet users. Users just go to Google and search "Download FireFox" and they download FireFox v.27.0 Stable Release.

I would kindly request you to test on FireFox v.27.0
Please!

@chinchang
Copy link
Owner

chinchang commented Feb 6, 2014

Let me test this on FF 27 and see whats wrong.

@pacanukeha
Copy link

pacanukeha commented Feb 6, 2014

I installed FF 27. No issues with the arrow on either my custom styled internal version, nor on the demo at kushagragour.in.

@swiftusa
Copy link
Author

swiftusa commented Feb 7, 2014

Okay I installed "Firefox Aurora v.28.0a2" on a new PC and see the same problem.
Please refer the attachment to see the screenshot of what I am seeing.
view

@swiftusa
Copy link
Author

swiftusa commented Feb 8, 2014

As per http://stackoverflow.com/questions/7394872/how-do-i-make-a-css-triangle-with-smooth-edges
adding "-moz-transform: scale(.9999);" to the http://jsfiddle.net/kirkaracha/TMP7H/ works in FireFox.

But I am not good in troubleshooting CSS and I do not know where to add the fix in hint.css.

Please help.

@chinchang
Copy link
Owner

chinchang commented Feb 8, 2014

@swiftusa Did you test the fix on your end? You can simple open the jsfiddle mentioned above and comment out the moz-transform property and see if it goes bad again.

@swiftusa
Copy link
Author

swiftusa commented Feb 8, 2014

The jsfiddle does not contain a " moz-transform" to comment out.

The http://jsfiddle.net/kirkaracha/TMP7H/ does not contain a "moz-transform"
When I add "-moz-transform: scale(.9999);" the jsfiddle triangle is smooth.

jsfiddle is only for your example and has nothing to do with hint.css.

I will need your help to identify where the "-moz-transform: scale(.9999);" has to be implemented in hint.css.

@swiftusa
Copy link
Author

swiftusa commented Feb 9, 2014

Okay I fixed it my self, and works perfectly on Firefox, Aurora and Chrome
But I have not tested on IE.

I First Removed border: 6px solid transparent; from the below line...

  .hint:before, [data-hint]:before {
    content: '';
    position: absolute;
    background: transparent;
    z-index: 1000001; }

Then Added The Following Lines

/**
 * set default color for tooltip arrows
 */
.hint--top:before {
  top: 0px;
  border-top: 6px solid transparent;
  border-right: 6px dotted transparent;
  border-left: 6px solid transparent;
  border-top-color: #383838; }

.hint--bottom:before {
  bottom: 0px;
  border-bottom: 6px solid transparent;
  border-right: 6px dotted transparent;
  border-left: 6px solid transparent;
  border-bottom-color: #383838; }

.hint--left:before {
  left: 0px;
  border-left: 6px solid transparent;
  border-top: 6px dotted transparent;
  border-bottom: 6px solid transparent;
  border-left-color: #383838; }

.hint--right:before {
  right: 0px;
  border-right: 6px solid transparent;
  border-top: 6px dotted transparent;
  border-bottom: 6px solid transparent;
  border-right-color: #383838; }

/**

Ref1: https://bugzilla.mozilla.org/show_bug.cgi?id=734748
Ref2: http://jsbin.com/opusan/1/edit

You will see that the above code variant does the same function as border: 6px solid transparent; the only change is dotted. Firefox requires one of the three elements to be dotted only then the jagged edges are fixed. I do not know why ??? but the problem is now FIXED 💯%.

:)

@amatriain
Copy link

amatriain commented Feb 13, 2014

@swiftusa would you consider creating a PR so @chinchang can consider including it in a future release?

@jonataswalker
Copy link

jonataswalker commented May 20, 2015

+1

@chinchang
Copy link
Owner

chinchang commented May 20, 2015

Is this issue still present on Firefox?

@jonataswalker
Copy link

jonataswalker commented May 20, 2015

Yeap. I've made the changes suggested and the triangle hint became much better.

@jonataswalker
Copy link

jonataswalker commented Jul 28, 2015

After all, the changes made by @swiftusa looks fine in Firefox but looks horrible in IE 11 so I've made some tests.

If I set:

.hint::before, [data-hint]::before {
    border-style: inset;
 }

I have some different colors on triangle. Plunker.

-moz-transform: scale(.9999); is not an option since it conflicts with transform: translateY(...);

So I ended up (plunker) changing to:

.hint::before, [data-hint]::before {
    border: 8px solid transparent;
}
/**and some other changes***/

Tested in Firefox, Chrome and IE 11.

@chinchang chinchang self-assigned this Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants