Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $hintSelector variable #158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ryanve
Copy link
Contributor

@ryanve ryanve commented Dec 15, 2016

This would allow customizing like

$hintSelector: '.hint';
$hintPrefix: 'hint--';

to use like

<div class="hint hint--top">example</div>

and make it easy to customize via .hint

@chinchang
Copy link
Owner

chinchang commented Dec 17, 2016

@ryanve Thanks for the pull request. I would just like to know if there was any use case of yours to change the selector of the tooltips?

@ryanve
Copy link
Contributor Author

ryanve commented Dec 20, 2016

Of course :) I'm using aria-label for the tooltip content so the only way to customize all tooltips would be by the somewhat cumbersome attribute selectors. Being able to use a simple base class like .hint seems cleaner and less error prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants