Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use !default for all variables #119

Merged
merged 1 commit into from Feb 14, 2016
Merged

Use !default for all variables #119

merged 1 commit into from Feb 14, 2016

Conversation

ryanve
Copy link
Contributor

@ryanve ryanve commented Feb 5, 2016

I'm not sure if there was a reason for skipping these but I think all variables should be overridable the same way. !default makes is so that the value is only set if the variable is not already set

@chinchang
Copy link
Owner

chinchang commented Feb 14, 2016

👍

chinchang added a commit that referenced this pull request Feb 14, 2016
@chinchang chinchang merged commit 5dc37cb into chinchang:master Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants