Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all variables. #117

Closed
wants to merge 3 commits into from
Closed

Prefix all variables. #117

wants to merge 3 commits into from

Conversation

CupOfTea696
Copy link
Contributor

@CupOfTea696 CupOfTea696 commented Feb 3, 2016

Added the prefix hint- to all variables, useful when including hint.css with your own sass code, to prevent any variable clashes.

@chinchang
Copy link
Owner

chinchang commented Feb 3, 2016

@CupOfTea696 This makes sense. I have just one concern: The variables now have mixed hyphen and camelcases. Eg. $hint-textShadowDarkenAmount which bothers me. How about $hintTextShadowDarkenAmount?

@chinchang
Copy link
Owner

chinchang commented Feb 14, 2016

👍 merged manually. Thanks.

@chinchang chinchang closed this Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants